Re: [PATCH] Error out if SKIP LOCKED and WITH TIES are both specified

From: David Christensen <david(dot)christensen(at)crunchydata(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Error out if SKIP LOCKED and WITH TIES are both specified
Date: 2021-08-30 20:55:10
Message-ID: CAOxo6XKFb5P5haRU+rZ1szF0-RDKCQ2kkW3utN1eLaPo3pkHZw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 30, 2021 at 3:51 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-Aug-13, David Christensen wrote:
>
> > Both bugs #16676[1] and #17141[2] illustrate that the combination of
> > SKIP LOCKED and FETCH FIRST WITH TIES break expectations when it comes
> > to rows returned to other sessions accessing the same row. Since this
> > situation is detectable from the syntax and hard to fix otherwise,
> > forbid for now, with the potential to fix in the future.
>
> I think we should do this, given that it has show potential to bite
> people. We should also add a small mentioned to this in the docs, as in
> the attached.
>
> What do others think?

The patch I included had a doc mention in roughly the same place (at
least the same file), but I'm not tied to the wording I used (and I
may have missed more than one spot that might be appropriate). In any
case, +1.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2021-08-30 21:05:29 Re: archive status ".ready" files may be created too early
Previous Message Alvaro Herrera 2021-08-30 20:51:27 Re: [PATCH] Error out if SKIP LOCKED and WITH TIES are both specified