Re: Map WAL segment files on PMEM as WAL buffers

From: Takashi Menjo <takashi(dot)menjo(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)fujitsu(dot)com>, "Deng, Gang" <gang(dot)deng(at)intel(dot)com>, Takashi Menjo <takashi(dot)menjou(dot)vg(at)hco(dot)ntt(dot)co(dot)jp>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: Map WAL segment files on PMEM as WAL buffers
Date: 2022-01-20 05:55:13
Message-ID: CAOwnP3PT3KX6LaDoLFAz642WvgPFx9UAzqJASkreR60iH-AtVA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Justin,

Here is patchset v8. It will have "make check-world" and Cirrus to
pass. Would you try this one?

The v8 squashes some patches in v7 into related ones, and adds the
following patches:

- v8-0003: Add wal_pmem_map to postgresql.conf.sample. It also helps v8-0011.

- v8-0009: Fix wrong handling of missingContrecPtr for
test/recovery/t/026 to pass. It is the cause of the error. Thanks for
your report.

- v8-0010 and v8-0011: Each of the two is for CI only. v8-0010 adds
--with-libpmem and v8-0011 enables "wal_pmem_map = on". Please note
that, unlike your suggestion, in my patchset PMEM_IS_PMEM_FORCE=1 will
be given as an environment variable in .cirrus.yml and "wal_pmem_map =
on" will be given by initdb.

Regards,
Takashi

--
Takashi Menjo <takashi(dot)menjo(at)gmail(dot)com>

Attachment Content-Type Size
v8-0001-Add-with-libpmem-option-for-PMEM-support.patch application/octet-stream 8.0 KB
v8-0002-Add-wal_pmem_map-to-GUC.patch application/octet-stream 5.1 KB
v8-0005-Map-WAL-segment-files-on-PMEM-as-WAL-buffers.patch application/octet-stream 19.0 KB
v8-0003-Add-wal_pmem_map-to-postgresql.conf.sample.patch application/octet-stream 1.0 KB
v8-0004-Export-InstallXLogFileSegment.patch application/octet-stream 2.1 KB
v8-0007-Update-document.patch application/octet-stream 2.0 KB
v8-0008-Preallocate-and-initialize-more-WAL-if-wal_pmem_m.patch application/octet-stream 3.6 KB
v8-0006-WAL-statistics-in-cases-of-wal_pmem_map-true.patch application/octet-stream 2.2 KB
v8-0009-Fix-wrong-handling-of-missingContrecPtr.patch application/octet-stream 1.1 KB
v8-0011-For-CI-only-Modify-initdb-for-wal_pmem_map-on.patch application/octet-stream 887 bytes
v8-0010-For-CI-only-Setup-Cirrus-CI-for-with-libpmem.patch application/octet-stream 3.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-01-20 06:07:22 Re: standby recovery fails (tablespace related) (tentative patch and discussion)
Previous Message Michael Paquier 2022-01-20 05:32:43 Re: Refactoring of compression options in pg_basebackup