Re: Broken lock management in policy.c.

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Broken lock management in policy.c.
Date: 2016-01-04 02:00:31
Message-ID: CAOuzzgqBjNOYHu4RJ9phG4CFcPzV2LycA0GiwL0=84w=1ZZjzw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter,

On Sunday, January 3, 2016, Peter Geoghegan <pg(at)heroku(dot)com> wrote:

> On Sun, Jan 3, 2016 at 5:18 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us <javascript:;>>
> wrote:
> > In any case, the text in create_policy.sgml seems to be a misleading
> > description of the problem, as it's talking about DDL modifications
> > which are *not* what's happening here.
>
> I'm not sure what you mean. The CREATE POLICY changes in commit
> 43cd468cf01007f3 specifically call out the issue illustrated in my
> example test case. There are some other changes made in that commit,
> but they don't seem to be attempting to address this specific problem.
> They also seem fine.
>

I believe Tom's complaint was that the overall page is about CREATE POLICY,
technically, and that the text in attempting to address the concern might
be taken under the context of being a CREATE POLICY issue rather than a
general RLS issue with row locking.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2016-01-04 02:04:32 Re: Broken lock management in policy.c.
Previous Message Peter Geoghegan 2016-01-04 01:56:55 Re: Broken lock management in policy.c.