Re: pg_dump emits ALTER TABLE ONLY partitioned_table

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Amit Langote <amitlangote09(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Date: 2017-05-06 03:28:18
Message-ID: CAOuzzgpmP8uDmqh9ekwR2VUakm_9=B1X6vyyZK+xazwK+s1Hug@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Noah,

On Fri, May 5, 2017 at 23:19 Noah Misch <noah(at)leadboat(dot)com> wrote:

> On Thu, May 04, 2017 at 05:47:02PM -0400, Stephen Frost wrote:
> > * Amit Langote (amitlangote09(at)gmail(dot)com) wrote:
> > > On Wed, May 3, 2017 at 12:05 PM, Stephen Frost <sfrost(at)snowman(dot)net>
> wrote:
> > > > Assuming this looks good to you, I'll push it tomorrow, possibly with
> > > > other minor adjustments and perhaps a few more tests.
> > >
> > > Your latest patch looks good to me.
> >
> > Found a few more issues (like pg_dump not working against older versions
> > of PG, because the queries for older versions hadn't been adjusted) and
> > did a bit more tidying.
> >
> > I'll push this in a couple of hours.
>
> This PostgreSQL 10 open item is past due for your status update. Kindly
> send
> a status update within 24 hours, and include a date for your subsequent
> status
> update. Refer to the policy on open item ownership:
>
> https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com
>
> I see you did commit a related patch. Is this item done?

Yes, I believe it to be. I anticipate reviewing the code in this area more
in the coming weeks, but this specific issue can be marked as resolved.

Thanks!

Stephen

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Vinayak Pokale 2017-05-06 03:38:38 Re: [PATCH] New command to monitor progression of long running queries
Previous Message Noah Misch 2017-05-06 03:17:49 Re: pg_dump emits ALTER TABLE ONLY partitioned_table