| From: | Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: warn if GUC set to an invalid shared library |
| Date: | 2022-01-08 21:32:53 |
| Message-ID: | CAOtHd0DO-9LoFogQL95A4mFyDgrn9yMxdOL4wmZXYewv7DeKrQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Dec 30, 2021 at 12:21 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> Overall the idea looks good to me. A warning on ALTER SYSTEM SET seems
> reasonable than nothing. ERROR isn't the way to go as it limits the
> users of setting the extensions in shared_preload_libraries first,
> installing them later. Is NOTICE here a better idea than WARNING?
I don't think so--I'm skeptical that "updated shared_preload_libraries
first, then install them" is much more than a theoretical use case. We
may not want to block that off completely, but I think a warning is
reasonable here, because you're *probably* doing something wrong if
you get to this message at all (and if you're not, you're probably
familiar enough with Postgres to know to ignore the warning).
Thanks,
Maciek
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-01-08 22:07:02 | Re: warn if GUC set to an invalid shared library |
| Previous Message | SATYANARAYANA NARLAPURAM | 2022-01-08 21:29:30 | Re: Logging replication state changes |