Re: [PATCH] Add Commit/Rollback toolbar action version 2

Hi Sanket,

Did you give the patch a try? I would really like it to for the next
release :)

-- john

2015-09-16 20:27 GMT+02:00 John Obaterspok <john(dot)obaterspok(at)gmail(dot)com>:

> Hi Sanket,
>
> Attached patch is rebased now.
>
> Regards,
>
> -- john
>
>
> 2015-09-16 11:20 GMT+02:00 Sanket Mehta <sanket(dot)mehta(at)enterprisedb(dot)com>:
>
>> Hi John,
>>
>> Patch is not proper.
>> I got below error when I try to apply the patch:
>>
>> error: patch failed: pgadmin/frm/frmQuery.cpp:2435
>> error: pgadmin/frm/frmQuery.cpp: patch does not apply
>>
>> Please do provide the proper patch.
>>
>>
>> Regards,
>> Sanket Mehta
>> Sr Software engineer
>> Enterprisedb
>>
>> On Mon, Sep 14, 2015 at 10:51 AM, Sanket Mehta <
>> sanket(dot)mehta(at)enterprisedb(dot)com> wrote:
>>
>>> Sure Ashesh,
>>>
>>> I will review the patch.
>>>
>>> Regards,
>>> Sanket Mehta
>>> Sr Software engineer
>>> Enterprisedb
>>>
>>> On Mon, Sep 14, 2015 at 1:12 PM, Ashesh Vashi <
>>> ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Sanket,
>>>>
>>>> Can you please take a look at it?
>>>>
>>>> --
>>>>
>>>> Thanks & Regards,
>>>>
>>>> Ashesh Vashi
>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>> <http://www.enterprisedb.com>
>>>>
>>>>
>>>> *http://www.linkedin.com/in/asheshvashi*
>>>> <http://www.linkedin.com/in/asheshvashi>
>>>>
>>>> On Mon, Sep 14, 2015 at 1:07 AM, John Obaterspok <
>>>> john(dot)obaterspok(at)gmail(dot)com> wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> I'm updated the patch to add commit/rollback actions in the toolbar
>>>>> with the following:
>>>>> 1) updated icons (based on existing pgadmin icon with arrows drawn by
>>>>> me)
>>>>> 2) add entry to menu as well
>>>>> 3) disable icons when not in a transaction
>>>>> 4) Ctrl+Shift C|R shortcut
>>>>>
>>>>> Hopefully all issues are resolved now!
>>>>>
>>>>> Regards,
>>>>>
>>>>> John
>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>>>>> To make changes to your subscription:
>>>>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>>>>
>>>>>
>>>>
>>>
>>
>