Re: [pgAdmin4][RM3136] Stabilise feature tests for continuous running on CI sytems

Hi Hackers,

Please find here attached patch for RM3136. It provides fixes for the
following two test cases

- pg_utilities_backup_restore_test.py
- pg_utilities_maintenance_test.py

The fixes include the followings

- Added the code to skip the assertion check for backup file name
for windows OS
- If Backup window(backup progress window) is not closed due to
some reason, it does not disappear even on refreshing page. Added the
code in after() method of test case to close it if it is still
visible(both backup and restore windows).
- Removed the line to maximise the backup windows.

Please review the patch and commit.

On Mon, Sep 10, 2018 at 5:18 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Thanks, patch applied (I've removed a screenshot call that seemed to be
> left there by mistake).
>
> On Fri, Sep 7, 2018 at 5:47 PM, Usman Muzaffar <
> usman(dot)muzaffar(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find here attached patch for query_tool_tests.py. On
>> Jenkins(windows platform), the test case was failing due to conflict for
>> Explain Option drop down which was not closed.
>> I have added the code on the required places and verified on all
>> platforms.
>>
>> Please review the patch and commit.
>>
>> On Tue, Aug 21, 2018 at 5:16 PM, Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Thanks patch applied with following changes:
>>>
>>> - Remove "*self._screenshot()" *method from each feature test as it
>>> will take screenshot every time even though test case will execute
>>> successfully.
>>> - Fix pep8 issues.
>>> - Remove unnecessary blank lines.
>>> - Change function name from "setTestDbName" to "setTestDatabaseName".
>>> - Modify some comments and strings.
>>>
>>>
>>> On Mon, Aug 20, 2018 at 6:18 PM, Usman Muzaffar <
>>> usman(dot)muzaffar(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Hackers,
>>>>
>>>> Attached is the patch for feature tests, mostly fix issues due to which
>>>> test cases were failing on jenkins. It has the following fixes,
>>>>
>>>>
>>>> - Added code to Create testing db node from runtests.py with random
>>>> number in name to avoid naming conflicts in parallel execution on different
>>>> platforms.
>>>> - Added code to delete testing db node from runtest.py.
>>>> - Removed the code to add and delete testing db with name
>>>> "acceptacne_test_db" in each feature test cases.
>>>> - Added `setTestDbName` method in route.py module , through which
>>>> testing db name will be available for all feature tests.
>>>> - xpath/css selectors changes where applicable. Where it was
>>>> possible I have used css selectors.
>>>> - sqleditor.js - added the code to render
>>>> Explain Options submenue on left side on small screen.
>>>> - Increased the timeout for application from 60 to 90 seconds.
>>>> - Change the logic for reset layout funciton.
>>>>
>>>>
>>>> Last successful execution on all platfroms can be seen on following link
>>>>
>>>> http://pgabf-jenkins.ox.uk.enterprisedb.com:8080/view/Featur
>>>> eTest%20(Adhoc)
>>>>
>>>> --
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Usman Muzaffar
>>>> QA Team
>>>> EnterpriseDB Corporation
>>>>
>>>
>>>
>>>
>>> --
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect *
>>>
>>>
>>>
>>> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>>>
>>
>>
>>
>> --
>>
>>
>> Thanks,
>>
>> Usman Muzaffar
>> QA Team
>> EnterpriseDB Corporation
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

--

Thanks,

Usman Muzaffar
QA Team
EnterpriseDB Corporation