| From: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Dipesh Pandit <dipesh(dot)pandit(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, jeevanladhe(dot)os(at)gmail(dot)com |
| Subject: | Re: refactoring basebackup.c |
| Date: | 2022-01-31 11:10:25 |
| Message-ID: | CAOgcT0OQ6bMwHa5sX-3UVPMPm8kt9_Ry8FrLZ7Upwr8-PY5P0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Robert,
I had an offline discussion with Dipesh, and he will be working on the
lz4 client side decompression part.
Please find the attached patch with the following changes:
- Even if we were going to support LZ4 only on the server side, surely
> it's not right to refuse --compress lz4 and --compress client-lz4 at
> the parsing stage. I don't even think the message you added to main()
> is reachable.
>
I think you are right, I have removed the message and again introduced
the Assert() back.
- In the new test case you set decompress_flags but according to the
> documentation I have here, -m is for multiple files (and so should not
> be needed here) and -d is for decompression (which is what we want
> here). So I'm confused why this is like this.
>
As explained earlier in the tap test the 'lz4 -d base.tar.lz4' command was
throwing the decompression to stdout. Now, I have removed the '-m',
added '-d' for decompression, and also added the target file explicitly in
the command.
Regards,
Jeevan Ladhe
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Add-a-LZ4-compression-method-for-server-side-compres.patch | application/octet-stream | 19.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2022-01-31 11:17:09 | Re: Make mesage at end-of-recovery less scary. |
| Previous Message | Andrey V. Lepikhov | 2022-01-31 09:59:17 | Re: Multiple Query IDs for a rewritten parse tree |