| From: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
|---|---|
| To: | amul sul <sulamul(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in pg_dump --table and --exclude-table for declarative partition table handling. |
| Date: | 2017-05-09 08:21:30 |
| Message-ID: | CAOgcT0N3JHJKcasd24_Zk-2rpf2Sk4LtTCVBgYoebPysTq-z8g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, May 9, 2017 at 12:43 PM, amul sul <sulamul(at)gmail(dot)com> wrote:
> Hi,
>
> Current pg_dump --exclude-table option excludes partitioned relation
> and dumps all its child relations and vice versa for --table option, which
> I think is incorrect.
>
> In this case we might need to explore all partitions and exclude or include
> from dump according to given pg_dump option, attaching WIP patch proposing
> same fix. Thoughts/Comments?
>
> Regards,
> Amul
>
+1.
Also, I can see similar issue exists with inheritance.
In attached patch, I have extended Amul's original patch to address the
inheritance dumping issue.
Regards,
Jeevan Ladhe
| Attachment | Content-Type | Size |
|---|---|---|
| pg_dump_fix_for_partition_and_inheritance.patch | application/octet-stream | 2.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2017-05-09 08:26:58 | Typos in comments in execMain.c |
| Previous Message | Masahiko Sawada | 2017-05-09 07:27:19 | Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) |