From: | Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com> |
---|---|
To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Bug in get_partition_for_tuple |
Date: | 2017-03-13 05:31:16 |
Message-ID: | CAOgcT0MFpo1=Z3Qpiub0KLGuqS1sxgVpNNoZ+nSrkKht1_ArrA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi Amit,
I was able to reproduce the crash, and with the attached patch the crash
goes
away. Also, "make check-world" passes clean.
Patch looks good to me. However, In following comment in your test:
-- check routing error through a list partitioned table when they key is
null
I think you want to say:
-- check routing error through a list partitioned table when the key is null
Thanks,
Jeevan Ladhe
On Fri, Mar 10, 2017 at 8:26 AM, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp
> wrote:
> Just observed a crash due to thinko in the logic that handles NULL
> partition key. Absence of null-accepting partition in this case should
> have caused an error, instead the current code proceeds with comparison
> resulting in crash.
>
> create table p (a int, b char) partition by list (b);
> create table p1 partition of p for values in ('a');
> insert into p values (1); -- crashes
>
> Attached patch fixes that and adds a test.
>
> Thanks,
> Amit
>
>
> --
> Sent via pgsql-hackers mailing list (pgsql-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-hackers
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Langote | 2017-03-13 05:41:13 | Re: Bug in get_partition_for_tuple |
Previous Message | Rajkumar Raghuwanshi | 2017-03-13 05:24:19 | Re: wait events for disk I/O |