| From: | Atri Sharma <atri(dot)jiit(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs |
| Date: | 2015-01-06 06:53:53 |
| Message-ID: | CAOeZVidVaBCMt3m=JfOd+P34Eww+HHP2GXfS=Y-=MzpDzykTcg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
>
>>
>> The overhead of this patch is small. A new path is added for the preorder
>> keys, and OrderCheck node's additional cost is pretty low, given that it
>> only compares two rows and stores only a single row (previous row seen),
>> hence the memory footprint is minuscule.
>>
>>
> We can eliminate the new node and put onus or having the right order on
> the user like we do with volatile setting of the function.
>
>
That is exactly what the new node does, since we are not re sorting right
now in case the order is wrong. Please see my explanation upthread,
OrderCheck node's primary purpose is to check for a user error in the
result rows order. The onus right now to give correct order is on user.
Regards,
Atri
--
Regards,
Atri
*l'apprenant*
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2015-01-06 06:59:26 | Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs |
| Previous Message | Ashutosh Bapat | 2015-01-06 06:50:58 | Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs |