| From: | Rahila Syed <rahila(dot)syed(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Euler Taveira <euler(dot)taveira(at)2ndquadrant(dot)com>, Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: More tests with USING INDEX replident and dropped indexes |
| Date: | 2020-09-02 03:57:33 |
| Message-ID: | CAOajBXR19oHSbHch5oJvmN28Zwd_eRAZRoBNV__zJct572bLYQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
>
>
> On the other hand, it looks appealing to make index_set_state_flags()
> transactional. This would solve the consistency problem, and looking
> at the code scanning pg_index, I don't see a reason why we could not
> do that. What do you think?
>
TBH, I am not sure. I think it is a reasonable change. It is even
indicated in the
comment above index_set_state_flags() that it can be made transactional.
At the same time, probably we can just go ahead with current
inconsistent update of relisreplident and indisvalid flags. Can't see what
will break with that.
Thank you,
--
Rahila Syed
Performance Engineer
2ndQuadrant
http://www.2ndQuadrant.com <http://www.2ndquadrant.com/>
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2020-09-02 04:02:54 | Re: Hybrid Hash/Nested Loop joins and caching results from subplans |
| Previous Message | k.jamison@fujitsu.com | 2020-09-02 03:48:55 | RE: [Patch] Optimize dropping of relation buffers using dlist |