Re: Apparent bug in WAL summarizer process (hung state)

From: Israel Barth Rubio <barthisrael(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Apparent bug in WAL summarizer process (hung state)
Date: 2024-06-27 19:31:57
Message-ID: CAO_rXXC7x5VrYeqdqNWALPAoLRyHMbqtGYzThr23N=KSBEj2CQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Yeah, this is a bug. It seems that the WAL summarizer process, when
> restarted, wants to restart from wherever it was previously
> summarizing WAL, which is correct if that WAL is still around, but if
> summarize_wal has been turned off in the meanwhile, it might not be
> correct. Here's a patch to fix that.

Thanks for checking this!

> Thanks. New version attached.

And besides that, thanks for the patch, of course!

I compiled Postgres locally with your patch. I attempted to break it several
times, both manually and through a shell script.

No success on that -- which in this case is actually success :)
The WAL summarizer seems able to always resume from a valid point,
so `pg_basebackup` isn't failing anymore.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2024-06-27 19:39:45 Re: Is missing LOGIN Event on Trigger Firing Matrix ?
Previous Message Marcos Pegoraro 2024-06-27 18:40:23 Is missing LOGIN Event on Trigger Firing Matrix ?