Re: PG_TEST_EXTRA and meson

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Cc: Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Tristan Partin <tristan(at)partin(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: PG_TEST_EXTRA and meson
Date: 2024-08-14 12:49:19
Message-ID: CAOYmi+=Fjz5hCxhv4hE+peW+oxOaRvogSNnM6dGsc=zx3W094g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 13, 2024 at 9:07 PM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> > I'm not entirely sure what you mean? src/test should work fine,
> > anything lower than that (say src/test/ssl) does not.
>
> I could run them from src/test/modules/xid_wraparound/. That's desirable.

On my machine, storing xid_wraparound into PG_TEST_EXTRA at configure
time and running `make check` from the modules/xid_wraparound
directory causes them to be skipped. Setting the environment variable
will continue to work at that directory level, though; my patch
shouldn't change that.

> What is working now should continue to work even after this change.
> PG_TEST_EXTRA="xyz" make check works right now.

Fair point, see attached.

Thanks,
--Jacob

Attachment Content-Type Size
v2-make_test_extra.diff application/octet-stream 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message vignesh C 2024-08-14 13:06:11 Re: Logical Replication of sequences
Previous Message Thomas Munro 2024-08-14 12:36:23 Re: macOS prefetching support