Re: Logical Replication of sequences

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Hou, Zhijie/侯 志杰 <houzj(dot)fnst(at)fujitsu(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
Subject: Re: Logical Replication of sequences
Date: 2024-08-14 13:06:11
Message-ID: CALDaNm0thvZ46Fq0=qrx4-0ph_+g-h0bvUsZeQ651kXFifXqUw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 14 Aug 2024 at 08:39, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Vignesh, Here are my review comments for the latest patchset:
>
> Patch v20240813-0001. No comments
> Patch v20240813-0002. No comments
> Patch v20240813-0003. No comments
> Patch v20240813-0004. See below
> Patch v20240813-0005. No comments
>
> //////
>
> Patch v20240813-0004
>

The comments have been addressed, and the patch also resolves a
limitation where sequence parameter changes between creating or
altering a subscription and sequence synchronization worker syncing
were not detected and reported to the user. This issue is now handled
by retrieving both the sequence value and its properties in a single
SELECT statement. The corresponding documentation also was updated.

The attached v20240814 version patch has the changes for the same.

Regards,
Vignesh

Attachment Content-Type Size
v20240814-0002-Introduce-ALL-SEQUENCES-support-for-Postgr.patch text/x-patch 90.4 KB
v20240814-0004-Enhance-sequence-synchronization-during-su.patch text/x-patch 92.8 KB
v20240814-0005-Documentation-for-sequence-synchronization.patch text/x-patch 23.1 KB
v20240814-0001-Introduce-pg_sequence_state-function-for-e.patch text/x-patch 11.4 KB
v20240814-0003-Reorganize-tablesync-Code-and-Introduce-sy.patch text/x-patch 14.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amul Sul 2024-08-14 13:19:57 Re: pg_verifybackup: TAR format backup verification
Previous Message Jacob Champion 2024-08-14 12:49:19 Re: PG_TEST_EXTRA and meson