| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [PATCH] Support older Pythons in oauth_server.py |
| Date: | 2025-04-22 22:42:57 |
| Message-ID: | CAOYmi+nh3sWi5K=ZM=ymoOtPwrDRC+qHhc4--L0CRhnF-esMcQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Apr 22, 2025 at 3:17 PM Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> wrote:
> The way you replaced this does not have the same behaviour in the case
> where the prefix/suffix is not part of the string. removeprefix/suffix
> will not remove any characters in that case, but your code will always
> remove the number of characters that the suffix/prefix is long. Maybe
> your other checks and definition of the OAuth spec ensure that these
> prefixes/suffixes are present when you remove them
Correct. Directly above the changed code are the prefix checks, which
set self._alt_issuer/_parameterized.
Thanks!
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2025-04-22 23:41:50 | Re: [PoC] Federated Authn/z with OAUTHBEARER |
| Previous Message | Tomas Vondra | 2025-04-22 22:38:01 | Re: AIO v2.5 |