Re: Feature-test macros for new-in-v17 libpq features

On Thu, Aug 22, 2024 at 10:16 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> In connection with that last point, I wonder if we should include
> commentary about when things came in. I'd originally thought of
> just inserting the above names in alphabetical order, but now I
> wonder if the patch ought to look more like
>
> */
> +/* Features added in PostgreSQL v14: */
> /* Indicates presence of PQenterPipelineMode and friends */
> #define LIBPQ_HAS_PIPELINING 1
> /* Indicates presence of PQsetTraceFlags; also new PQtrace output format */
> #define LIBPQ_HAS_TRACE_FLAGS 1
> +/* Features added in PostgreSQL v15: */
> /* Indicates that PQsslAttribute(NULL, "library") is useful */
> #define LIBPQ_HAS_SSL_LIBRARY_DETECTION 1
> +/* Features added in PostgreSQL v17: */
> + ... as above ...

+1, I like the new headers and keeping the version order.

Thanks!
--Jacob