Re: sslinfo extension - add notbefore and notafter timestamps

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Cary Huang <cary(dot)huang(at)highgo(dot)ca>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: sslinfo extension - add notbefore and notafter timestamps
Date: 2024-03-18 13:34:16
Message-ID: CAOYmi+md2bcO1tYOkVNoO2C26a3xOqYctd6FeHueduZHuEmd1g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Mar 8, 2024 at 4:16 PM Cary Huang <cary(dot)huang(at)highgo(dot)ca> wrote:
> Yes, I noticed this in the SSL test too. I am also in GTM-8, so for me the tests would fail too due to the time zone differences from GMT. It shall be okay to specifically set the outputs of pg_stat_ssl, ssl_client_get_notbefore, and ssl_client_get_notafte to be in GMT time zone. The not before and not after time stamps in a client certificate are generally expressed in GMT.

Hi Cary, did you have any thoughts on the timestamptz notes from my last mail?

> It might also be nice to rename
> ASN1_TIME_to_timestamp().
>
> Squinting further at the server backend implementation, should that
> also be using TimestampTz throughout, instead of Timestamp? It all
> goes through float8_timestamptz at the end, so I guess it shouldn't
> have a material impact, but it's a bit confusing.

Thanks,
--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2024-03-18 13:35:38 Re: What about Perl autodie?
Previous Message Daniel Gustafsson 2024-03-18 13:33:46 Re: Is there still password max length restrictions in PG?