| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Offsets of `struct Port` are no longer constant |
| Date: | 2024-11-11 16:34:48 |
| Message-ID: | CAOYmi+mKVJNzn5_TD_MK=hqO64r_w8Gb0FHCLk0oAkW-PJv8jQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
A comment at the end of the Port struct says
/*
* OpenSSL structures. (Keep these last so that the locations of other
* fields are the same whether or not you build with SSL enabled.)
*/
but as part of the direct-SSL changes in d39a49c1e45 (cc'd Heikki),
some additional fields snuck in after it.
I assume it's too late to change this for 17, but should this be
addressed in HEAD? I've attached a draft patch (untested, beware)
which should no longer rely on field order.
Thanks,
--Jacob
| Attachment | Content-Type | Size |
|---|---|---|
| port-offset.diff | application/octet-stream | 654 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bernd Helmle | 2024-11-11 16:41:25 | Re: [PATCH] Add sortsupport for range types and btree_gist |
| Previous Message | Robert Haas | 2024-11-11 16:30:18 | Re: Eager aggregation, take 3 |