Re: jsonapi: scary new warnings with LTO enabled

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: jsonapi: scary new warnings with LTO enabled
Date: 2025-04-23 00:01:44
Message-ID: CAOYmi+kKB7CLsJEauEH8afsZLx2f2RdLtDPLAW2kHztPcR7oHA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Apr 22, 2025 at 3:10 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
> My preference is that no operation can silently work on a failed object, but
> it's not a hill (even more so given where we are in the cycle).

Hm, okay. Something to talk about with Andrew and Peter, maybe.

> The attached
> v3 allocates via the JSON api, no specific error handling should be required as
> it's already handled today.

pgindent shows one whitespace change on my machine (comment
indentation), but other than that, LGTM! Fuzzers are happy too.

Thanks,
--Jacob

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Steve Chavez 2025-04-23 00:18:39 Re: Allow database owners to CREATE EVENT TRIGGER
Previous Message Tatsuo Ishii 2025-04-22 23:55:33 Re: Row pattern recognition