| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Euler Taveira <euler(dot)taveira(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Subject: | Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible |
| Date: | 2025-03-06 23:39:44 |
| Message-ID: | CAOYmi+kHY8HZ5RdXGT1bVZzkAq7ta=--YSGehLr35HRjF4Fyug@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 6, 2025 at 3:15 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> I have applied the simplest patch for now, to silence the failures in
> the CI, and included your suggestion to add a check on the
> backend_type for the extra safety it offers.
Thanks! Initial CI run looks green, so that's a good start.
I've reattached the wait event patches, to get the cfbot back to where it was.
> I'd like the addition of the poll_query_until() in the long-term, but
> I'm really not sure if the semantics would be right this way under a
> background psql. In the auth 007 test, they would be OK, but it could
> be surprising if we have other callers that begin relying on it.
Yeah, that API is definitely subtle.
--Jacob
| Attachment | Content-Type | Size |
|---|---|---|
| v11-0001-Report-external-auth-calls-as-wait-events.patch | application/octet-stream | 13.0 KB |
| v11-0002-squash-Report-external-auth-calls-as-wait-events.patch | application/octet-stream | 5.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2025-03-06 23:48:36 | Re: Commitfest app release on Feb 17 with many improvements |
| Previous Message | Robert Haas | 2025-03-06 23:32:06 | Re: explain analyze rows=%.0f |