Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible

On Tue, Nov 5, 2024 at 9:48 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> +PAM_ACCT_MGMT "Waiting for the local PAM service to validate the user account."
> +PAM_AUTHENTICATE "Waiting for the local PAM service to authenticate the user."
>
> Is "local" required for both? Perhaps just use "the PAM service".

Done in v5.

> +SSPI_LOOKUP_ACCOUNT_SID "Waiting for Windows to find the user's account SID."
>
> We don't document SID in doc/. So perhaps this should add be "SID
> (system identifier)".

I switched to "user's security identifier", which seems to be
search-engine-friendly.

On Wed, Nov 6, 2024 at 7:15 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> 0002 has been done as ba08edb06545 after adding a bit more
> documentation that was missing. 0001 as well with 70291a3c66ec.

Thanks!

> Note that 0003 is lacking an EXTRA_INSTALL in the Makefile of
> src/test/authentication/, or the test would fail if doing for example
> a `make check` in this path.
>
> The following nit is also required in the script for installcheck, to
> skip the test if the module is not installed:
> if (!$node->check_extension('injection_points'))
> {
> plan skip_all => 'Extension injection_points not installed';
> }

Fixed.

> 007_injection_points.pl is a name too generic as it could apply in a
> lot more places, without being linked to injection points. How about
> something like 007_pre_auth.pl?

Renamed.

Thanks!
--Jacob