Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible

From: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Euler Taveira <euler(dot)taveira(at)enterprisedb(dot)com>
Subject: Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible
Date: 2025-02-10 19:05:32
Message-ID: CAOYmi+=7fN+Y=oOT5eBKFpmVryFSUnnVz2ZQk65Jaq8LbnMnAg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 10, 2025 at 8:23 AM Jacob Champion
<jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> The test is supposed to enforce that, but I see that it's not for some
> reason. That's concerning. I'll investigate, thanks for pointing it
> out.

Bad regex escaping on my part; fixed in v8. Thanks for the report!

While debugging, I also noticed that a poorly timed autovacuum could
also show up in my new pg_stat_activity query, so I've increased the
specificity.

> Do we _want_ nine separate flavors of WAIT_EVENT_LDAP_UNBIND? I
> figured it was enough to know that you were stuck unbinding.

v8-0003 shows this approach. For the record, I think it's materially
worse than v7-0003. IMO it increases the cognitive load for very
little benefit and makes it more work for a newcomer to refactor the
cleanup code for those routines. I think it's enough that you can see
a separate LOG message for each failure case, if you want to know why
we're unbinding.

Thanks,
--Jacob

Attachment Content-Type Size
since-v7.diff.txt text/plain 1.8 KB
v8-0001-pgstat-report-in-earlier-with-STATE_STARTING.patch application/octet-stream 23.2 KB
v8-0002-Report-external-auth-calls-as-wait-events.patch application/octet-stream 13.0 KB
v8-0003-squash-Report-external-auth-calls-as-wait-events.patch application/octet-stream 5.3 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melih Mutlu 2025-02-10 19:09:42 Re: speedup COPY TO for partitioned table.
Previous Message Alexander Lakhin 2025-02-10 19:00:00 Re: Improving the latch handling between logical replication launcher and worker processes.