| From: | Kohei KaiGai <kaigai(at)heterodb(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Is MaxHeapAttributeNumber a reasonable restriction for foreign-tables? |
| Date: | 2021-02-04 07:24:01 |
| Message-ID: | CAOP8fzZGXO-3GSgiLVY71xmgcQb4f0dO=5kz47vVrALaxHe_wQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
I noticed that CheckAttributeNamesTypes() prevents to create a table that has
more than MaxHeapAttributeNumber (1600) columns, for foreign-table also.
IIUC, this magic number comes from length of the null-bitmap can be covered
with t_hoff in HeapTupleHeaderData.
For heap-tables, it seems to me a reasonable restriction to prevent overrun of
null-bitmap. On the other hand, do we have proper reason to apply same
restrictions on foreign-tables also?
Foreign-tables have their own unique internal data structures instead of
the PostgreSQL's heap-table, and some of foreign-data can have thousands
attributes in their structured data.
I think that MaxHeapAttributeNumber is a senseless restriction for foreign-
tables. How about your opinions?
Best regards,
--
HeteroDB, Inc / The PG-Strom Project
KaiGai Kohei <kaigai(at)heterodb(dot)com>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2021-02-04 07:28:29 | Re: Correct comment in StartupXLOG(). |
| Previous Message | Michael Paquier | 2021-02-04 07:08:43 | Re: Typo in tablesync comment |