Re: PgBouncer 1.24.0 - New upstream version

On Tue, Feb 4, 2025 at 7:06 AM Christoph Berg <cb(at)df7cb(dot)de> wrote:
>
> Unfortunately that needs more work as it looks like:
>
> bookworm and others:
>
> 14:54:22 E AttributeError: 'PGconn' object has no attribute 'close_prepared'
>
> https://jengus.postgresql.org/job/pgbouncer-binaries/106/architecture=amd64,distribution=bookworm/console

Yeah -- it looks like close_prepared was added in psycopg 3.2.0 and
bookworm has 3.1.7. I could patch the tests to include a skipif based on
the version of psycopg.

> bullseye doesn't have python3-psycopg (and building that doesn't look
> trivial). Do we think we could go without or with less tests there?

I think we could go without tests on bullseye since it seems like we are
nearing the trixie release and bullseye will become old old stable.
(Correct me if I am wrong on this point, I'm making this assumption
based on the trixie freeze dates). There's probably little value in
creating extra work here.

It looks like d/rules for pgbouncer will skip the tests if nocheck is in
DEB_BUILD_OPTIONS -- is this something that can be configured via the Jenkins
YAML? I am not very familiar with the Jenkins job builder YAML and I didn't see
any usages of that in the current set of jobs. Or would I need to update
generate-pgdg-source to include an additional tweak to disable the tests on
older platforms?

Thanks,
-- Bradford