| From: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Patch for SonarQube code scan fixes |
| Date: | 2020-07-01 11:52:52 |
| Message-ID: | CAOBg0AP50o3PH7LQiH8u1LGR8QmkA+FM9REL6m5D42CGxtRcog@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Team,
I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Functions files:
- Remove the unused local variable "args"
2. node.js file in browser/static:
- "j" hides or potentially hides a variable declared in an outer scope
at line 1080.
3. FTS Templates files:
- Refactor this function to reduce its Cognitive Complexity from 22 to
the 15 allowed.
4. FTS Parsers files:
- Refactor this function to reduce its Cognitive Complexity from 22 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 16 to
the 15 allowed.
5. FTS Dictionaries files:
- Refactor this function to reduce its Cognitive Complexity from 25 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 16 to
the 15 allowed.
6. FTS Configurations files:
- Refactor this function to reduce its Cognitive Complexity from 22 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 16 to
the 15 allowed.
Regards,
Nikhil Mohite.
| Attachment | Content-Type | Size |
|---|---|---|
| SonarQube_code_smell_for_FTS.patch | application/octet-stream | 18.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2020-07-01 11:55:15 | Re: Patch for SonarQube code scan fixes |
| Previous Message | Akshay Joshi | 2020-07-01 10:04:03 | pgAdmin 4 commit: Fix PEP8 |