Re: Patch for SonarQube code scan.

From: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
To: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for SonarQube code scan.
Date: 2020-06-26 04:32:47
Message-ID: CAOBg0AP-nUW0cpVYFj+jf7e0S9yWZMNu9_emKY3b+7LRSY0RxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Khushboo,

Details as follows:
1. Package files:

1. Refactor this function to reduce its Cognitive Complexity from 40 to the
15 allowed.
2. Refactor this function to reduce its Cognitive Complexity from 16 to the
15 allowed.

2. Functions files:

1. Rename this local variable "argString" to match the regular expression
^[_a-z][a-z0-9_]*$.
2. Refactor this function to reduce its Cognitive Complexity from 16 to the
15 allowed.

Thanks,
Nikhil Mohite.

On Fri, Jun 26, 2020 at 9:48 AM Khushboo Vashi <
khushboo(dot)vashi(at)enterprisedb(dot)com> wrote:

> Hi Nikhil,
>
> Can you please provide the details of the issue provided by SonarQube (so
> review would be easy) ?
>
> Thanks,
> Khushboo
>
> On Fri, Jun 26, 2020 at 9:31 AM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Team,
>>
>> I have fixed some code smell issues in SonarQube scan.
>> 1. Code smells in packages init file.
>> 2. Code smells in function init file (not fixed all code smell will send
>> new path for it).
>>
>> Regards,
>> Nikhil Mohite.
>>
>>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2020-06-26 04:38:04 Re: Patch for SonarQube code scan.
Previous Message Khushboo Vashi 2020-06-26 04:18:37 Re: Patch for SonarQube code scan.