Re: [pgAdmin][RM-6687]: [React] Port Grant Wizard to react

Hi Akshay,

Please find the updated patch for grant wizard (v4). (Resolved all review
comments.)

On Tue, Sep 21, 2021 at 12:02 PM Aditya Toshniwal <
aditya(dot)toshniwal(at)enterprisedb(dot)com> wrote:

> Hi Nikhil,
>
> Sorry for the late review. I have a few points:
> 1. Components should always start with caps. Rename pgTable to PgTable.
> 2. File names should be the same as component names. Rename
> grantWizard.jsx to GrantWizard.jsx
> 3. Please remove the empty file - table.jsx
> 4. Basic components should go in web/pgadmin/static/js/components whereas
> advanced ones can go in pgadmin/static/js/helpers. Please move PgTable to
> components.
> 5. Create a directory Wizard inside helpers and put WizardStep and
> WizardView components inside the directory.
>
>
It will be easy to maintain if we follow certain conventions.
>

> On Mon, Sep 20, 2021 at 1:07 PM Akshay Joshi <
> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>
>> Thanks, the patch applied.
>>
>> On Thu, Sep 16, 2021 at 11:22 AM Nikhil Mohite <
>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Akshay,
>>>
>>> Please find the updated patch (v3) resolved all review comments.
>>>
>>> On Tue, Sep 14, 2021 at 6:13 PM Akshay Joshi <
>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Nikhil
>>>>
>>>> Following are the GUI related review comments:
>>>>
>>>> 1. Remove the header string "Object selection (step 1 of 3) as we
>>>> are already showing steps on the left side of the wizard.
>>>>
>>>> Done
>>>
>>>>
>>>> 1. Rename step 1 to "Object Selection" step 2 to
>>>> "Privilege Selection" and step 3 to "Review Selection".
>>>>
>>>> Done
>>>
>>>>
>>>> 1. The search button is not implemented on the first page (object
>>>> selection).
>>>>
>>>> Done
>>>
>>>>
>>>> 1. The help button is not implemented at the bottom left corner of
>>>> the wizard.
>>>>
>>>> Done
>>>
>>>>
>>>> 1. Duplicate entries are found on the object selection page. (Seems
>>>> like an old issue without this patch)
>>>>
>>>> I tried but was unable to detect the exact issue.
>>>
>>>>
>>>> 1. Checkbox checked color should be matched with the theme.
>>>>
>>>> Done
>>>
>>>>
>>>> 1. Scrollbar alignment is not correct and spaces at the right side
>>>> and bottom look ugly.
>>>>
>>>> Done
>>>
>>>>
>>>> 1. The grantor should be set and read-only.
>>>>
>>>> Done
>>>
>>>>
>>>> 1. Showing all privileges instead of based on the selected node.
>>>> Please refer to existing behavior.
>>>>
>>>> Done
>>>
>>>> Refer screenshot with all above review comments
>>>>
>>>> [image: Object Selection.png]
>>>> :
>>>>
>>>>
>>>>
>>>> On Tue, Sep 14, 2021 at 1:19 PM Nikhil Mohite <
>>>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>>>
>>>>> Hi Hackers,
>>>>>
>>>>> Please find the updated patch for grant wizard porting to react.
>>>>> (Please ignore the previous patch)
>>>>>
>>>>> On Tue, Sep 14, 2021 at 10:05 AM Nikhil Mohite <
>>>>> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Hackers,
>>>>>>
>>>>>> Please find the attached patch for
>>>>>> <https://redmine.postgresql.org/issues/6672>RM-6687:
>>>>>> <https://redmine.postgresql.org/issues/6687>[React] Port Grant
>>>>>> Wizard to react
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Thanks & Regards,*
>>>>>> *Nikhil Mohite*
>>>>>> *Software Engineer.*
>>>>>> *EDB Postgres* <https://www.enterprisedb.com/>
>>>>>> *Mob.No: +91-7798364578.*
>>>>>>
>>>>>
>>>>> Regards,
>>>>> Nikhil Mohite
>>>>>
>>>>
>>>>
>>>> --
>>>> *Thanks & Regards*
>>>> *Akshay Joshi*
>>>> *pgAdmin Hacker | Principal Software Architect*
>>>> *EDB Postgres <http://edbpostgres.com>*
>>>>
>>>> *Mobile: +91 976-788-8246*
>>>>
>>> Regards,
>>> Nikhil Mohite
>>>
>>
>>
>> --
>> *Thanks & Regards*
>> *Akshay Joshi*
>> *pgAdmin Hacker | Principal Software Architect*
>> *EDB Postgres <http://edbpostgres.com>*
>>
>> *Mobile: +91 976-788-8246*
>>
>
>
> --
> Thanks,
> Aditya Toshniwal
> pgAdmin Hacker | Software Architect | *edbpostgres.com*
> <http://edbpostgres.com>
> "Don't Complain about Heat, Plant a TREE"
>

Regards,
Nikhil Mohite