| From: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Patch for SonarQube code scan fixes |
| Date: | 2020-07-16 13:45:23 |
| Message-ID: | CAOBg0AO8KkPAbu2zqNctr8UWkSKQtV6HPFU8Gd9cCTyvF=FZ-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Team,
I have fixed some code smell issues in the SonarQube scan, PFA patch.
Details as follows:
1. Servers file(utils):
- Refactor this function to reduce its Cognitive Complexity from 19 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 33 to
the 15 allowed.
2. Tablespaces init file:
- Refactor this function to reduce its Cognitive Complexity from 48 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 32 to
the 15 allowed.
3. Server Roles init file:
- Refactor this function to reduce its Cognitive Complexity from 52 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 34 to
the 15 allowed.
4. Resource Groups init file:
- Refactor this function to reduce its Cognitive Complexity from 29 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 21 to
the 15 allowed.
- Refactor this function to reduce its Cognitive Complexity from 17 to
the 15 allowed.
*In Server roles file one code smell is pending, I will share that in the
next patch.
Regards,
Nikhil Mohite
| Attachment | Content-Type | Size |
|---|---|---|
| sonarQubeCodeSmellFixes.patch | application/octet-stream | 34.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-07-16 14:23:53 | pgAdmin 4 commit: Fixed code smell 'potential hiding of variables decla |
| Previous Message | Nikhil Mohite | 2020-07-16 13:13:41 | [pgAdmin][RM5653]: High Contrast UI Theme |