Patch for SonarQube fixes.

From: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Patch for SonarQube fixes.
Date: 2021-01-18 05:45:39
Message-ID: CAOBg0AO3tVZMT68DyMLyc6w+za9sHA+NHEs_rosfVGNP=kgxeQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Team,

I have fixed a few sonarQube issues, PFA patch
Details as follows:

1. Preferences:

- Refactor this function to reduce its Cognitive Complexity from 18 to
the 15 allowed.
- Merge this if statement with the enclosing one.
- Define a constant instead of duplicating this literal 'tab settings' 5
times.

2. Connection:

- Remove this unneeded "pass".

3. Sqleditor:

- Remove this useless assignment to variable "msgDiv".

4. Debugger:

- Review this useless assignment: "index" already holds the assigned
value along all execution paths.
- 'label' is already declared in the upper scope.
- 'label' is already declared in the upper scope.
- 'browser_preferences' is already declared in the upper scope.

5. FileManager:

- 'path' is already declared in the upper scope.

--
*Thanks & Regards,*
*Nikhil Mohite*
*Software Engineer.*
*EDB Postgres* <https://www.enterprisedb.com/>
*Mob.No: +91-7798364578.*

Attachment Content-Type Size
SonarQubeCodeSmellFixes.patch application/octet-stream 14.2 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Khushboo Vashi 2021-01-18 07:30:37 Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1
Previous Message Aditya Toshniwal 2021-01-18 05:03:32 Re: [pgAdmin][RM1802] ERD Tool (Beta)