From: | Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com> |
---|---|
To: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Patch for SonarQube code scan fixes |
Date: | 2020-07-07 04:57:35 |
Message-ID: | CAOBg0ANRirE2gnOcPyHBA7w8qhgXo=18qYBvSHELbdjzo9iRqw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Akshay,
I have resolved the PEP8 issues, PFA updated patch.
Regards,
Nikhil Mohite.
On Tue, Jul 7, 2020 at 10:19 AM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:
> Hi Nikhil
>
> Fix the PEP8 issues.
>
> On Tue, Jul 7, 2020 at 9:35 AM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Team,
>>
>> I have fixed some code smell issues in the SonarQube scan, PFA patch.
>> Details as follows:
>> 1. Table Index files(utils and init):
>>
>> - Refactor this function to reduce its Cognitive Complexity from 27
>> to the 15 allowed.
>> - Refactor this function to reduce its Cognitive Complexity from 20
>> to the 15 allowed.
>> - Refactor this function to reduce its Cognitive Complexity from 18
>> to the 15 allowed.
>> - Refactor this function to reduce its Cognitive Complexity from 16
>> to the 15 allowed.
>> - Refactor this function to reduce its Cognitive Complexity from 22
>> to the 15 allowed.
>>
>>
>> Regards,
>> Nikhil Mohite.
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>
Attachment | Content-Type | Size |
---|---|---|
sonarQubeCodeSmell_v2.patch | application/octet-stream | 9.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Yogesh Mahajan | 2020-07-07 06:31:58 | [pgAdmin4][Patch] - SonarQube Issues - 9 (Variables and functions should not be redeclared, Variables should not be shadowed) |
Previous Message | Akshay Joshi | 2020-07-07 04:53:08 | Re: [pgAdmin][RM5622]: Permissive or restricted policy on table from PG 10 and above |