Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

From: Nikhil Mohite <nikhil(dot)mohite(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL
Date: 2021-05-10 14:01:47
Message-ID: CAOBg0AMVyLBma8wsbZ-VQWF4q3OAhqWeRLpmrxVcM_YOKH+MDQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave/ Team,

PFA updated patch, sorry for the inconvenience, while cleanup I removed the
unwanted libraries but forgot to remove the code related to them.

On Mon, May 10, 2021 at 7:10 PM Dave Page <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Mon, May 10, 2021 at 1:45 PM Nikhil Mohite <
> nikhil(dot)mohite(at)enterprisedb(dot)com> wrote:
>
>> Hi Hackers,
>>
>> Please find the attached patch for RM-2341
>> <https://redmine.postgresql.org/issues/2341>: Add Menu option for
>> starting PSQL.
>> 1. Added new Option PSQL Tool in Tools menu.
>> 2. Added the same option for Server and Database nodes from the tree view.
>>
>
> Unfortunately there's a trailing comma in package.json that makes it
> invalid. If I fix that, then I get the error below, so I'm guessing the
> intention was to actually include another package there?
>
> ERROR in ./pgadmin/tools/psql/static/js/psql_module.js 23:50-82
> Module not found: Error: Can't resolve 'local-echo-controller' in
> '/Users/dpage/git/pgadmin4/web/pgadmin/tools/psql/static/js'
> resolve 'local-echo-controller' in
> '/Users/dpage/git/pgadmin4/web/pgadmin/tools/psql/static/js'
> Parsed request is a module
> using description file: /Users/dpage/git/pgadmin4/web/package.json
> (relative path: ./pgadmin/tools/psql/static/js)
> aliased with mapping 'local-echo-controller':
> '/Users/dpage/git/pgadmin4/web/node_modules/local-echo' to
> '/Users/dpage/git/pgadmin4/web/node_modules/local-echo'
> using description file: /Users/dpage/git/pgadmin4/web/package.json
> (relative path: ./pgadmin/tools/psql/static/js)
> Field 'browser' doesn't contain a valid alias configuration
> root path /Users/dpage/git/pgadmin4/web
> using description file:
> /Users/dpage/git/pgadmin4/web/package.json (relative path:
> ./Users/dpage/git/pgadmin4/web/node_modules/local-echo)
> no extension
> Field 'browser' doesn't contain a valid alias configuration
>
> /Users/dpage/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/node_modules/local-echo
> doesn't exist
> .js
> Field 'browser' doesn't contain a valid alias configuration
>
> /Users/dpage/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/node_modules/local-echo.js
> doesn't exist
> .jsx
> Field 'browser' doesn't contain a valid alias configuration
>
> /Users/dpage/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/node_modules/local-echo.jsx
> doesn't exist
> as directory
>
> /Users/dpage/git/pgadmin4/web/Users/dpage/git/pgadmin4/web/node_modules/local-echo
> doesn't exist
> using description file: /Users/dpage/git/pgadmin4/web/package.json
> (relative path: ./node_modules/local-echo)
> no extension
> Field 'browser' doesn't contain a valid alias configuration
> /Users/dpage/git/pgadmin4/web/node_modules/local-echo doesn't
> exist
> .js
> Field 'browser' doesn't contain a valid alias configuration
> /Users/dpage/git/pgadmin4/web/node_modules/local-echo.js
> doesn't exist
> .jsx
> Field 'browser' doesn't contain a valid alias configuration
> /Users/dpage/git/pgadmin4/web/node_modules/local-echo.jsx
> doesn't exist
> as directory
> /Users/dpage/git/pgadmin4/web/node_modules/local-echo doesn't
> exist
> @ ./pgadmin/tools/psql/static/js/index.js 17:19-43
>
> 2021-05-10 14:38:37: webpack 5.21.2 compiled with 1 error in 60041 ms
>
> --
> Dave Page
> Blog: https://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EDB: https://www.enterprisedb.com
>

Regards,
Nikhil Mohite

Attachment Content-Type Size
RM_2341_V2.patch application/octet-stream 111.7 KB

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Aditya Toshniwal 2021-05-11 07:03:22 [pgAdmin][RM5477] Cache bust webpack chunk files
Previous Message Dave Page 2021-05-10 13:40:39 Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL