Re: Avoid incorrect allocation in buildIndexArray

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Avoid incorrect allocation in buildIndexArray
Date: 2020-09-11 11:49:26
Message-ID: CAOBaU_biM4rV7cdYVZkY5T3D9hXQWV5Gyiz9uecszLLo7CpqTA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 11, 2020 at 1:39 PM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> Looking at a pg_dump patch I realized that when we call buildIndexArray without
> having found objects to index, we still call pg_malloc with zero which in turn
> mallocs 1 byte. The byte in question is of course negligable, but it does seem
> cleaner to return early with NULL instead of returning an empty allocation
> which doesn't actually contain an index.
>
> Any reason not to bail early as per the attached?

+1

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2020-09-11 11:56:58 Re: Avoid incorrect allocation in buildIndexArray
Previous Message Daniel Gustafsson 2020-09-11 11:38:29 Avoid incorrect allocation in buildIndexArray