From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Hans Buschmann <buschmann(at)nidsa(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: PG14: Avoid checking output-buffer-length for every encoded byte during pg_hex_encode |
Date: | 2021-08-17 16:34:45 |
Message-ID: | CAOBaU_bUAjMbjO39wHKjG==XPK-RBBh-JfCd8v3VES0txr70rQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 17, 2021 at 11:26 PM Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>
> On Tue, Aug 17, 2021 at 09:39:30AM -0400, Tom Lane wrote:
> > Michael Paquier <michael(at)paquier(dot)xyz> writes:
> > > In short, I am planning to address this regression with the attached,
> > > for a combined revert of 0d70d30, 5c33ba5 and 92436a7.
> >
> > OK, but the commit message should explain why they're getting reverted.
>
> Uh, I don't see those commits, e.g.:
>
> $ git diff 0d70d30
> fatal: ambiguous argument '0d70d30': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
>
> $ git diff 5c33ba5
> fatal: ambiguous argument '5c33ba5': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
>
> $ git diff 92436a7
> fatal: ambiguous argument '92436a7': unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions, like this:
> 'git <command> [<revision>...] -- [<file>...]'
Same here. I'm assuming that the real commits are the one mentioned
in the patch, which are c3826f8, aef8948 and ccf4e27.
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2021-08-17 16:42:55 | Re: preserving db/ts/relfilenode OIDs across pg_upgrade (was Re: storing an explicit nonce) |
Previous Message | Bossart, Nathan | 2021-08-17 16:33:54 | Re: .ready and .done files considered harmful |