Re: pgsql: Centralize horizon determination for temp tables, fixing bug due

On Thu, Oct 29, 2020 at 9:07 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Centralize horizon determination for temp tables, fixing bug due to skew.

Lapwing just reported some problem
(https://brekka.postgresql.org/cgi-bin/show_log.pl?nm=lapwing&dt=2020-10-29%2002%3A40%3A14)

=======================
1 of 93 tests failed.
=======================

The differences that caused some tests to fail can be viewed in the
file "/home/postgres/buildroot/HEAD/pgsql.build/src/test/isolation/output_iso/regression.diffs".
A copy of the test summary that you see
above is saved in the file
"/home/postgres/buildroot/HEAD/pgsql.build/src/test/isolation/output_iso/regression.out".

make: *** [installcheck] Error 1

==================
pgsql.build/src/test/isolation/output_iso/regression.diffs
===================
diff -U3 /home/postgres/buildroot/HEAD/pgsql.build/src/test/isolation/expected/horizons.out
/home/postgres/buildroot/HEAD/pgsql.build/src/test/isolation/output_iso/results/horizons.out
--- /home/postgres/buildroot/HEAD/pgsql.build/src/test/isolation/expected/horizons.out
2020-10-29 02:40:12.270207507 +0000
+++ /home/postgres/buildroot/HEAD/pgsql.build/src/test/isolation/output_iso/results/horizons.out
2020-10-29 03:18:10.456577467 +0000
@@ -52,7 +52,7 @@

?column?

-2
+0
step ll_commit: COMMIT;
step pruner_drop:
DROP TABLE horizons_tst;
@@ -219,7 +219,7 @@

?column?

-2
+0
step ll_commit: COMMIT;
step pruner_drop:
DROP TABLE horizons_tst;