From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Sergei Kornilov <sk(at)zsrv(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Add parallelism and glibc dependent only options to reindexdb |
Date: | 2019-07-27 09:44:47 |
Message-ID: | CAOBaU_b=P+H9EZZuZ+kMEScz6iHpz8S3ZMrrrZcQ6zWmWJ425Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jul 26, 2019 at 9:41 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jul 26, 2019 at 09:36:32AM +0200, Julien Rouhaud wrote:
> > I see that you iterate over the SimpleStringList after it's generated.
> > Why not computing that while building it in get_parallel_object_list
> > (and keep the provided table list count) instead?
>
> Yeah. I was hesitating to do that, or just break out of the counting
> loop if there are more objects than concurrent jobs, but that's less
> intuitive.
That's probably still more intuitive than having the count coming from
either main() or from get_parallel_object_list() depending on the
process type, so I'm fine with that alternative. Maybe we could bite
the bullet and add a count meber to Simple*List, also providing a
macro to initialize a new list so that next time a field is added
there won't be a massive boilerplate code change?
From | Date | Subject | |
---|---|---|---|
Next Message | Dave Cramer | 2019-07-27 10:40:00 | Re: Built-in connection pooler |
Previous Message | Thomas Munro | 2019-07-27 09:40:35 | Re: LLVM compile failing in seawasp |