| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Arthur Zakirov <zaartur(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Atsushi Torikoshi <atorik(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add pg_file_sync() to adminpack |
| Date: | 2020-01-24 06:31:06 |
| Message-ID: | CAOBaU_ag0rZ7Vd6n1yp1sAnyxAGp7JG=VUVmOZMtq4+tbYJV4g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 24, 2020 at 6:56 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Jan 24, 2020 at 01:28:29PM +0900, Arthur Zakirov wrote:
> > It is compiled and passes the tests. There is the documentation and it is
> > built too without an error.
> >
> > It seems that consensus about the returned type was reached and I marked the
> > patch as "Ready for Commiter".
>
> + fsync_fname_ext(filename, S_ISDIR(fst.st_mode), false, ERROR);
> One comment here: should we warn better users in the docs that a fsync
> failule will not trigger a PANIC here? Here, fsync failure on heap
> file => ERROR => potential data corruption.
Definitely yes.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Arthur Zakirov | 2020-01-24 06:38:11 | Re: Add pg_file_sync() to adminpack |
| Previous Message | Masahiko Sawada | 2020-01-24 06:00:50 | Re: Transactions involving multiple postgres foreign servers, take 2 |