Re: pg_bsd_indent and -Wimplicit-fallthrough

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>, postgres(at)piotr-stefaniak(dot)me
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_bsd_indent and -Wimplicit-fallthrough
Date: 2020-05-15 12:15:53
Message-ID: CAOBaU_a485UAUrQ2FyBEUVSm77qYF9M79eNxdiKS+Hq3vsAggA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 15, 2020 at 9:17 AM Daniel Gustafsson <daniel(at)yesql(dot)se> wrote:
>
> > On 15 May 2020, at 08:28, Julien Rouhaud <rjuju123(at)gmail(dot)com> wrote:
> > On Fri, May 15, 2020 at 8:03 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> >> Something like the attached is fine to take care of those warnings,
> >> but what's our current patching policy for this tool?
> >
> > The patch looks good to me. It looks like we already have custom
> > patches, so +1 to applying it.
>
> Shouldn't we try and propose it to upstream first to minimize our diff?

Good point, adding Piotr.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2020-05-15 12:15:59 Re: ldap tls test fails in some environments
Previous Message Dilip Kumar 2020-05-15 11:50:55 Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions