Misleading comment in pg_upgrade.c

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Misleading comment in pg_upgrade.c
Date: 2019-12-05 09:17:54
Message-ID: CAOBaU_a2iviTG7FE10yO_gcW+zQCHNFhRA_NDiktf3UR65BHdw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

While reading pg_upgrade code to restore the objects on the new
cluster, I noticed that 5b570d771b8 didn't adjust the database name in
the comments explaining the requirements for an extra "--clean" for
template1 and postgres databases. While it's true that both databases
will already exist, I found it confusing to mention both names when
only one is processed for each code path.

Attachment Content-Type Size
fix_pgupgrade_comment.diff application/octet-stream 1.4 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Konstantin Knizhnik 2019-12-05 09:23:40 Re: Session WAL activity
Previous Message Daniel Gustafsson 2019-12-05 09:03:27 Re: Update minimum SSL version