Re: track_planning causing performance regression

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, "Tharakan, Robins" <tharar(at)amazon(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: track_planning causing performance regression
Date: 2021-07-07 09:09:21
Message-ID: CAOBaU_ZxTGMapnWTCGaEiAHochUjzEB5XQN3hqbuf0xspDwSbg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 1, 2021 at 4:28 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>
> I'm fine with this. So what about the following diff? I added <structname> tag.
>
> <varname>pg_stat_statements.track_planning</varname> controls whether
> planning operations and duration are tracked by the module.
> Enabling this parameter may incur a noticeable performance penalty,
> - especially when a fewer kinds of queries are executed on many
> - concurrent connections.
> + especially when statements with identical query structure are executed
> + by many concurrent connections which compete to update a small number of
> + <structname>pg_stat_statements</structname> entries.
> The default value is <literal>off</literal>.
> Only superusers can change this setting.

It seems perfect, thanks!

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2021-07-07 09:25:56 Re: Hook for extensible parsing.
Previous Message Andy Fan 2021-07-07 09:00:05 Re: Keep notnullattrs in RelOptInfo (Was part of UniqueKey patch series)