| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Track block level checksum failures in pg_stat_database |
| Date: | 2019-05-01 10:11:57 |
| Message-ID: | CAOBaU_ZqYVg5_o4CTz3PTbqmwBdf8PfXeoohibrbwcxS+GW=mw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, May 1, 2019 at 12:04 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> Looks good to me in general
>
> I don't see the reasoning behind changing the name from msg_autovacuum to msg_autovacuum_start anywhere, perhaps I missed a part of the discussion? Was that a change intended to be part of it?
That wasn't discussed, I should have mentioned it sorry. I just
changed it for consistency while at it, as it seemed a little bit
ambiguous or error prone:
PgStat_MsgAutovacStart -> msg_autovacuum
PgStat_MsgVacuum -> msg_vacuum
As the member of the union weren't used anywhere, I thought it's ok to
rename it now they're used. I'm not strongly attached to this change,
so feel free to discard it.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2019-05-01 10:34:51 | Re: pgsql: Track block level checksum failures in pg_stat_database |
| Previous Message | Magnus Hagander | 2019-05-01 10:04:30 | Re: pgsql: Track block level checksum failures in pg_stat_database |