Re: Hypothetical indexes using BRIN broken since pg10

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Hypothetical indexes using BRIN broken since pg10
Date: 2019-06-28 05:49:00
Message-ID: CAOBaU_ZDDr9cZ+HaSHk8WCPHW0-wY-YtwwgnCffFgB1MLe_DNQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 27, 2019 at 10:09 PM Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
>
> On 2019-Jun-27, Tom Lane wrote:
>
> > Dunno, I just can't get excited about exposing REVMAP_PAGE_MAXITEMS.
> > Especially not since we seem to agree on the long-term solution here,
> > and what you're suggesting to Julien doesn't particularly fit into
> > that long-term solution.
>
> Well, it was brin_page.h, which is supposed to be internal to BRIN
> itself. But since we admit that in its current state selfuncs.c is not
> salvageable as a module and we'll redo the whole thing in the short
> term, I withdraw my comment.

Thanks. I'll also work soon on a patch to move the [am]costestimate
functions in the am-specific files.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Oleg Bartunov 2019-06-28 06:00:30 Re: SQL/JSON path issues/questions
Previous Message Thomas Munro 2019-06-28 05:36:07 Re: An out-of-date comment in nodeIndexonlyscan.c