Re: WAL usage calculation patch

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Kirill Bychik <kirill(dot)bychik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Subject: Re: WAL usage calculation patch
Date: 2020-04-19 14:22:26
Message-ID: CAOBaU_Z5dK=cMXTaEEgXNCY7GrsBnVfk4vwK2h7o+2Aowb33Qw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Justin,

Thanks for the review!

On Sat, Apr 18, 2020 at 10:41 PM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
>
> Should capitalize at least the non-text one ? And maybe the text one for
> consistency ?
>
> + ExplainPropertyInteger("WAL fpw", NULL,

I think we should keep both version consistent, whether lower or upper
case. The uppercase version is probably more correct, but it's a
little bit weird to have it being the only upper case label in all
output, so I kept it lower case.

> And add the acronym to the docs:
>
> $ git grep 'full page' '*/explain.sgml'
> doc/src/sgml/ref/explain.sgml: number of records, number of full page writes and amount of WAL bytes
>
> "..full page writes (FPW).."

Indeed! Fixed (using lowercase to match current output).

> Should we also change vacuumlazy.c for consistency ?
>
> + _("WAL usage: %ld records, %ld full page writes, "
> + UINT64_FORMAT " bytes"),

I don't think this one should be changed, vacuumlazy output is already
entirely different, and is way more verbose so keeping it as is makes
sense to me.

Attachment Content-Type Size
v2-fix_explain_wal_output.diff text/x-patch 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ranier Vilela 2020-04-19 14:24:38 [PATCH] Small optimization across postgres (remove strlen duplicate usage)
Previous Message James Coleman 2020-04-19 13:46:55 Re: [PATCH] Incremental sort (was: PoC: Partial sort)