Re: pg_bsd_indent and -Wimplicit-fallthrough

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_bsd_indent and -Wimplicit-fallthrough
Date: 2020-05-15 06:28:20
Message-ID: CAOBaU_YxQantZbG1n+N6gOVuAhEOF+Pt+PZ5YkV7+KzqacWvKw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, May 15, 2020 at 8:03 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Hi,
>
> I have just noticed that pg_bsd_indent complains since
> -Wimplicit-fallthrough=3 has been added to the default set of switches
> if available.

Oh Indeed.

> Something like the attached is fine to take care of those warnings,
> but what's our current patching policy for this tool?

The patch looks good to me. It looks like we already have custom
patches, so +1 to applying it.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-05-15 06:55:19 Re: PG 13 release notes, first draft
Previous Message Fujii Masao 2020-05-15 06:10:38 Re: documenting the backup manifest file format