| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, "Jamison, Kirk" <k(dot)jamison(at)jp(dot)fujitsu(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: reloption to prevent VACUUM from truncating empty pages at the end of relation |
| Date: | 2019-02-25 07:47:28 |
| Message-ID: | CAOBaU_YUto9qW=RmqfGn6gUqdKrB8L1Pw1CG=ng37xxRdD2Fww@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 25, 2019 at 7:56 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Mon, Feb 25, 2019 at 02:38:05AM +0000, Tsunakawa, Takayuki wrote:
> > From: Julien Rouhaud [mailto:rjuju123(at)gmail(dot)com]
> >> One last thing, I think we should at least add one regression test for
> >> this setting. The one you provided previously seems perfectly suited.
> >
> > Thanks, added.
>
> +SELECT pg_relation_size('reloptions_test');
> + pg_relation_size
> +------------------
> + 8192
> +(1 row)
> This makes the test page-size sensitive. While we don't ensure that
> tests can be run with different page sizes, we should make a maximum
> effort to keep the tests compatible if that's easy enough. In this
> case you could just use > 0 as base comparison. I can fix that by
> myself, so no need to send a new version.
Ah good point. We could also use something like
pg_relation_size('reloptions_test') /
current_setting('block_size')::bigint but >0 should be enough for this
test.
> Should we also document that the parameter is effective for
> autovacuum? The name can lead to confusion regarding that.
+1
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2019-02-25 07:50:30 | Re: Copy function for logical replication slots |
| Previous Message | hubert depesz lubaczewski | 2019-02-25 07:45:39 | Segfault when restoring -Fd dump on current HEAD |