Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Postgres hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
Date: 2018-04-10 08:08:16
Message-ID: CAOBaU_YH=g68opbbMk8is3jNwhoXGa8ckRSre1nx0Obe1C7i-Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Hi,

On Mon, Apr 9, 2018 at 10:46 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> After further contemplation I decided that that was, in fact, the only
> reasonable way to improve matters. If we have multiple subdirectories
> independently firing the "make generated-headers" action, then we have
> parallel make hazards of just the same sort I was trying to prevent.
> So it's really an all-or-nothing proposition. The MAKELEVEL hack
> plus wiring the prerequisite into the recursion rules is the best way
> to make that happen.
>
> Hence, done that way.

Compilation of external extensions using PGXS appears to be broken
since this commit:

make[1]: *** /tmp/pgbuild/lib/postgresql/pgxs/src/makefiles/../../src/backend:
No such file or directory. Stop.
make: *** [/tmp/pgbuild/lib/postgresql/pgxs/src/makefiles/../../src/Makefile.global:370:
submake-generated-headers] Error 2

I think the best fix if to define NO_GENERATED_HEADERS in pgxs.mk,
patch attached.

Attachment Content-Type Size
fix_pgxs.diff text/x-patch 397 bytes

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2018-04-10 09:03:39 Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
Previous Message Michael Paquier 2018-04-10 07:24:35 Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2018-04-10 08:14:53 crash with sql language partition support function
Previous Message Michael Paquier 2018-04-10 07:24:35 Re: pgsql: Store 2PC GID in commit/abort WAL recs for logical decoding