| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Track block level checksum failures in pg_stat_database |
| Date: | 2019-04-30 21:41:55 |
| Message-ID: | CAOBaU_Y0oSe=nQLujkj_GD-KKC29rtfUL-Eb66w4a=XaC7rumA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, Apr 30, 2019 at 6:33 PM Tomas Vondra
<tomas(dot)vondra(at)2ndquadrant(dot)com> wrote:
>
> On Sat, Mar 09, 2019 at 06:48:11PM +0000, Magnus Hagander wrote:
> >Track block level checksum failures in pg_stat_database
> >
> >This adds a column that counts how many checksum failures have occurred
> >on files belonging to a specific database. Both checksum failures
> >during normal backend processing and those created when a base backup
> >detects a checksum failure are counted.
> >
>
> It seems this commit forgot to add PgStat_MsgChecksumFailure to the
> PgStat_Msg union.
Oops, indeed. That's embarrassing. Trivial fix attached if that helps.
| Attachment | Content-Type | Size |
|---|---|---|
| fix_pgstat_msg-v1.diff | text/x-patch | 383 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2019-04-30 21:56:47 | Re: pgsql: Track block level checksum failures in pg_stat_database |
| Previous Message | Tom Lane | 2019-04-30 19:04:09 | pgsql: Clean up handling of constraint_exclusion and enable_partition_p |