Re: Patch for RM1720 [pgadmin4]

From: Navnath Gadakh <navnath(dot)gadakh(at)enterprisedb(dot)com>
To: Dave Page <dpage(at)pgadmin(dot)org>
Cc: Harshal Dhumal <harshal(dot)dhumal(at)enterprisedb(dot)com>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Re: Patch for RM1720 [pgadmin4]
Date: 2016-09-21 15:02:39
Message-ID: CAOAJCYqs3Dj7+twOQqbsd7mSaHprnSY2E8vbh794=iJMdGCJ6w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hi Dave,
Can you please run testsuite for server or database node only, as
there are some code modifications are remaining on the rest of the nodes.
Currently i don't have a machine to look into issue, will check it tomorrow.

Thanks.

On 21-Sep-2016 6:50 PM, "Dave Page" <dpage(at)pgadmin(dot)org> wrote:

> Hi
>
> On Wed, Sep 21, 2016 at 1:57 PM, Harshal Dhumal
> <harshal(dot)dhumal(at)enterprisedb(dot)com> wrote:
> > Hi,
> >
> > PFA patch for RM1720
> >
> >
> > Issue: In pgAdmin4 we use server id (sid, which is id of server table in
> > sqlite db) as key to keep track of server connection (server manger). But
> > sqlite reuses these ids and therefore pgadmin4 connection manager assigns
> > connection details of one database server to another in some cases.
> >
> > To avoid this issue we now deleting server connection details (server
> > manger) when user drops server.
>
> Looks like it still needs some work I'm afraid (though, I think the
> approach is correct). Here's what I get running the regression tests:
>
> Interestingly; the error seen when running the test against PG 9.4
> isn't detected as a failure. Can you look at that aspect please
> Navnath?
>
>
> (pgadmin4)piranha:web dpage$ python regression/runtests.py
> pgAdmin 4 - Application Initialisation
> ======================================
>
>
> The configuration database - '/Users/dpage/.pgadmin/test_pgadmin4.db'
> does not exist.
> Entering initial setup mode...
> NOTE: Configuring authentication for SERVER mode.
>
>
> The configuration database has been created at
> /Users/dpage/.pgadmin/test_pgadmin4.db
>
> =============Running the test cases for 'Regression - PG 9.4'=============
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_add.DatabaseAddTestCase)
> This function will add database under 1st server of tree node. (Check
> Databases Node URL) ... ok
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_delete.DatabaseDeleteTestCase)
> This function will delete the database. (Check Databases Node URL) ... ok
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_get.DatabasesGetTestCase)
> This function will fetch added database. (Check Databases Node URL) ... ok
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_put.DatabasesUpdateTestCase)
> This function will update the comments field of database. (Check
> Databases Node) ... ok
> runTest (pgadmin.browser.server_groups.servers.tests.test_
> server_add.ServersAddTestCase)
> This function will add the server under default server group. (Default
> Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.servers.tests.test_server_delete.
> ServerDeleteTestCase)
> This function deletes the added server (Default Server Node url) ...
> 2016-09-21 14:15:58,737: ERROR pgadmin: 'NoneType' object has no
> attribute 'release'
> Traceback (most recent call last):
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/__init__.py",
> line 355, in delete
> get_driver(PG_DEFAULT_DRIVER).delete_manager(sid)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/
> psycopg2/__init__.py",
> line 1729, in delete_manager
> manager.release()
> AttributeError: 'NoneType' object has no attribute 'release'
> ok
> runTest (pgadmin.browser.server_groups.servers.tests.test_
> server_get.ServersGetTestCase)
> This function will fetch the added servers to object browser. (Default
> Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.servers.tests.test_server_put.
> ServerUpdateTestCase)
> This function update the server details (Default Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNodeTestCase)
> This function will check available server groups. (Check Server Group
> Node) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating Incorrect_New_Password) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating New_Password_Less_Than_Min_Length) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating Empty_New_Password) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating Incorrect_Current_Password) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Changing Valid_Password) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (TestCase for Checking
> Invalid_Password) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Empty_Password) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Empty_Email) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Empty_Credentials) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Invalid_Email) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Invalid_Credentials) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Valid_Credentials) ... ok
> runTest (pgadmin.browser.tests.test_logout.LogoutTest)
> This function checks the logout functionality. (Logging Out) ... ok
> runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> This function checks reset password functionality. (TestCase for
> Validating Empty Email) ... ok
> runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> This function checks reset password functionality. (TestCase for
> Validating Invalid_Email) ... ok
> runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> This function checks reset password functionality. (TestCase for
> Validating Valid_Email) ... ok
>
> ----------------------------------------------------------------------
> Ran 25 tests in 11.024s
>
> OK
>
> =============Running the test cases for 'Regression - PG 9.5'=============
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_add.DatabaseAddTestCase)
> This function will add database under 1st server of tree node. (Check
> Databases Node URL) ... ok
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_delete.DatabaseDeleteTestCase)
> This function will delete the database. (Check Databases Node URL) ... FAIL
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_get.DatabasesGetTestCase)
> This function will fetch added database. (Check Databases Node URL) ...
> ERROR
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_put.DatabasesUpdateTestCase)
> This function will update the comments field of database. (Check
> Databases Node) ... ERROR
> runTest (pgadmin.browser.server_groups.servers.tests.test_
> server_add.ServersAddTestCase)
> This function will add the server under default server group. (Default
> Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.servers.tests.test_server_delete.
> ServerDeleteTestCase)
> This function deletes the added server (Default Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.servers.tests.test_
> server_get.ServersGetTestCase)
> This function will fetch the added servers to object browser. (Default
> Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.servers.tests.test_server_put.
> ServerUpdateTestCase)
> This function update the server details (Default Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNodeTestCase)
> This function will check available server groups. (Check Server Group
> Node) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating Incorrect_New_Password) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating New_Password_Less_Than_Min_Length) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating Empty_New_Password) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating Incorrect_Current_Password) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Changing Valid_Password) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (TestCase for Checking
> Invalid_Password) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Empty_Password) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Empty_Email) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Empty_Credentials) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Invalid_Email) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Invalid_Credentials) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Valid_Credentials) ... ok
> runTest (pgadmin.browser.tests.test_logout.LogoutTest)
> This function checks the logout functionality. (Logging Out) ... ok
> runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> This function checks reset password functionality. (TestCase for
> Validating Empty Email) ... ok
> runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> This function checks reset password functionality. (TestCase for
> Validating Invalid_Email) ... ok
> runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> This function checks reset password functionality. (TestCase for
> Validating Valid_Email) ... ok
>
> ======================================================================
> ERROR: runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_get.DatabasesGetTestCase)
> This function will fetch added database. (Check Databases Node URL)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/tests/test_db_get.py",
> line 33, in runTest
> self.db_id)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/tests/utils.py",
> line 142, in verify_database
> follow_redirects=True)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 788, in post
> return self.open(*args, **kw)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/testing.py",
> line 113, in open
> follow_redirects=follow_redirects)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 751, in open
> response = self.run_wsgi_app(environ, buffered=buffered)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 668, in run_wsgi_app
> rv = run_wsgi_app(self.application, environ, buffered=buffered)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 871, in run_wsgi_app
> app_rv = app(environ, start_response)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 2000, in __call__
> return self.wsgi_app(environ, start_response)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1991, in wsgi_app
> response = self.make_response(self.handle_exception(e))
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1567, in handle_exception
> reraise(exc_type, exc_value, tb)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1988, in wsgi_app
> response = self.full_dispatch_request()
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1641, in full_dispatch_request
> rv = self.handle_user_exception(e)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1544, in handle_user_exception
> reraise(exc_type, exc_value, tb)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1639, in full_dispatch_request
> rv = self.dispatch_request()
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1625, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/views.py",
> line 84, in view
> return self.dispatch_request(*args, **kwargs)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line
> 235, in dispatch_request
> return method(*args, **kwargs)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/__init__.py",
> line 364, in connect
> conn = manager.connection(did=did, auto_reconnect=True)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/
> psycopg2/__init__.py",
> line 1448, in connection
> "Couldn't find the specified database."
> Exception: Couldn't find the specified database.
>
> ======================================================================
> ERROR: runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_put.DatabasesUpdateTestCase)
> This function will update the comments field of database. (Check Databases
> Node)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/tests/test_db_put.py",
> line 37, in runTest
> db_id)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/tests/utils.py",
> line 142, in verify_database
> follow_redirects=True)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 788, in post
> return self.open(*args, **kw)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/testing.py",
> line 113, in open
> follow_redirects=follow_redirects)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 751, in open
> response = self.run_wsgi_app(environ, buffered=buffered)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 668, in run_wsgi_app
> rv = run_wsgi_app(self.application, environ, buffered=buffered)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 871, in run_wsgi_app
> app_rv = app(environ, start_response)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 2000, in __call__
> return self.wsgi_app(environ, start_response)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1991, in wsgi_app
> response = self.make_response(self.handle_exception(e))
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1567, in handle_exception
> reraise(exc_type, exc_value, tb)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1988, in wsgi_app
> response = self.full_dispatch_request()
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1641, in full_dispatch_request
> rv = self.handle_user_exception(e)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1544, in handle_user_exception
> reraise(exc_type, exc_value, tb)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1639, in full_dispatch_request
> rv = self.dispatch_request()
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1625, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/views.py",
> line 84, in view
> return self.dispatch_request(*args, **kwargs)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line
> 235, in dispatch_request
> return method(*args, **kwargs)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/__init__.py",
> line 364, in connect
> conn = manager.connection(did=did, auto_reconnect=True)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/
> psycopg2/__init__.py",
> line 1448, in connection
> "Couldn't find the specified database."
> Exception: Couldn't find the specified database.
>
> ======================================================================
> FAIL: runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_delete.DatabaseDeleteTestCase)
> This function will delete the database. (Check Databases Node URL)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/tests/test_db_delete.py",
> line 38, in runTest
> self.assertEquals(response.status_code, 200)
> AssertionError: 410 != 200
>
> ----------------------------------------------------------------------
> Ran 25 tests in 10.845s
>
> FAILED (failures=1, errors=2)
>
> =============Running the test cases for 'Regression - EPAS
> 9.5'=============
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_add.DatabaseAddTestCase)
> This function will add database under 1st server of tree node. (Check
> Databases Node URL) ... ok
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_delete.DatabaseDeleteTestCase)
> This function will delete the database. (Check Databases Node URL) ... FAIL
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_get.DatabasesGetTestCase)
> This function will fetch added database. (Check Databases Node URL) ...
> ERROR
> runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_put.DatabasesUpdateTestCase)
> This function will update the comments field of database. (Check
> Databases Node) ... ERROR
> runTest (pgadmin.browser.server_groups.servers.tests.test_
> server_add.ServersAddTestCase)
> This function will add the server under default server group. (Default
> Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.servers.tests.test_server_delete.
> ServerDeleteTestCase)
> This function deletes the added server (Default Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.servers.tests.test_
> server_get.ServersGetTestCase)
> This function will fetch the added servers to object browser. (Default
> Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.servers.tests.test_server_put.
> ServerUpdateTestCase)
> This function update the server details (Default Server Node url) ... ok
> runTest (pgadmin.browser.server_groups.tests.test_sg_get.SgNodeTestCase)
> This function will check available server groups. (Check Server Group
> Node) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating Incorrect_New_Password) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating New_Password_Less_Than_Min_Length) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating Empty_New_Password) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Validating Incorrect_Current_Password) ... ok
> runTest (pgadmin.browser.tests.test_change_password.
> ChangePasswordTestCase)
> This function will check change password functionality. (TestCase for
> Changing Valid_Password) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (TestCase for Checking
> Invalid_Password) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Empty_Password) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Empty_Email) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Empty_Credentials) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Invalid_Email) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Invalid_Credentials) ... ok
> runTest (pgadmin.browser.tests.test_login.LoginTestCase)
> This function checks login functionality. (Valid_Credentials) ... ok
> runTest (pgadmin.browser.tests.test_logout.LogoutTest)
> This function checks the logout functionality. (Logging Out) ... ok
> runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> This function checks reset password functionality. (TestCase for
> Validating Empty Email) ... ok
> runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> This function checks reset password functionality. (TestCase for
> Validating Invalid_Email) ... ok
> runTest (pgadmin.browser.tests.test_reset_password.ResetPasswordTestCase)
> This function checks reset password functionality. (TestCase for
> Validating Valid_Email) ... ok
>
> ======================================================================
> ERROR: runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_get.DatabasesGetTestCase)
> This function will fetch added database. (Check Databases Node URL)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/tests/test_db_get.py",
> line 33, in runTest
> self.db_id)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/tests/utils.py",
> line 142, in verify_database
> follow_redirects=True)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 788, in post
> return self.open(*args, **kw)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/testing.py",
> line 113, in open
> follow_redirects=follow_redirects)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 751, in open
> response = self.run_wsgi_app(environ, buffered=buffered)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 668, in run_wsgi_app
> rv = run_wsgi_app(self.application, environ, buffered=buffered)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 871, in run_wsgi_app
> app_rv = app(environ, start_response)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 2000, in __call__
> return self.wsgi_app(environ, start_response)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1991, in wsgi_app
> response = self.make_response(self.handle_exception(e))
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1567, in handle_exception
> reraise(exc_type, exc_value, tb)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1988, in wsgi_app
> response = self.full_dispatch_request()
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1641, in full_dispatch_request
> rv = self.handle_user_exception(e)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1544, in handle_user_exception
> reraise(exc_type, exc_value, tb)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1639, in full_dispatch_request
> rv = self.dispatch_request()
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1625, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/views.py",
> line 84, in view
> return self.dispatch_request(*args, **kwargs)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line
> 235, in dispatch_request
> return method(*args, **kwargs)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/__init__.py",
> line 364, in connect
> conn = manager.connection(did=did, auto_reconnect=True)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/
> psycopg2/__init__.py",
> line 1448, in connection
> "Couldn't find the specified database."
> Exception: Couldn't find the specified database.
>
> ======================================================================
> ERROR: runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_put.DatabasesUpdateTestCase)
> This function will update the comments field of database. (Check Databases
> Node)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/tests/test_db_put.py",
> line 37, in runTest
> db_id)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/tests/utils.py",
> line 142, in verify_database
> follow_redirects=True)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 788, in post
> return self.open(*args, **kw)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/testing.py",
> line 113, in open
> follow_redirects=follow_redirects)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 751, in open
> response = self.run_wsgi_app(environ, buffered=buffered)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 668, in run_wsgi_app
> rv = run_wsgi_app(self.application, environ, buffered=buffered)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/werkzeug/test.py",
> line 871, in run_wsgi_app
> app_rv = app(environ, start_response)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 2000, in __call__
> return self.wsgi_app(environ, start_response)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1991, in wsgi_app
> response = self.make_response(self.handle_exception(e))
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1567, in handle_exception
> reraise(exc_type, exc_value, tb)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1988, in wsgi_app
> response = self.full_dispatch_request()
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1641, in full_dispatch_request
> rv = self.handle_user_exception(e)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1544, in handle_user_exception
> reraise(exc_type, exc_value, tb)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1639, in full_dispatch_request
> rv = self.dispatch_request()
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/app.py",
> line 1625, in dispatch_request
> return self.view_functions[rule.endpoint](**req.view_args)
> File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-
> packages/flask/views.py",
> line 84, in view
> return self.dispatch_request(*args, **kwargs)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/utils.py", line
> 235, in dispatch_request
> return method(*args, **kwargs)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/__init__.py",
> line 364, in connect
> conn = manager.connection(did=did, auto_reconnect=True)
> File "/Users/dpage/git/pgadmin4/web/pgadmin/utils/driver/
> psycopg2/__init__.py",
> line 1448, in connection
> "Couldn't find the specified database."
> Exception: Couldn't find the specified database.
>
> ======================================================================
> FAIL: runTest (pgadmin.browser.server_groups.servers.databases.
> tests.test_db_delete.DatabaseDeleteTestCase)
> This function will delete the database. (Check Databases Node URL)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/dpage/git/pgadmin4/web/pgadmin/browser/server_
> groups/servers/databases/tests/test_db_delete.py",
> line 38, in runTest
> self.assertEquals(response.status_code, 200)
> AssertionError: 410 != 200
>
> ----------------------------------------------------------------------
> Ran 25 tests in 13.194s
>
> FAILED (failures=1, errors=2)
>
> Test Result Summary
> ============================
> Regression - EPAS 9.5: 22 tests passed, 3 tests failed :
> DatabaseDeleteTestCase
> DatabasesGetTestCase
> DatabasesUpdateTestCase
> Regression - PG 9.5: 22 tests passed, 3 tests failed :
> DatabaseDeleteTestCase
> DatabasesGetTestCase
> DatabasesUpdateTestCase
> Regression - PG 9.4: 25 tests passed, 0 tests failed
> ============================
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2016-09-21 15:09:02 Re: Patch for RM1720 [pgadmin4]
Previous Message Surinder Kumar 2016-09-21 13:40:35 Re: [pgAdmin4][Patch]: RM1171 - Fix IE caching issue