Re: pgAdmin IV : Unittest modular patch

Hi Dave,

On Thu, Aug 4, 2016 at 4:04 PM, Dave Page <dave(dot)page(at)enterprisedb(dot)com>
wrote:

> Hi
>
> On Thu, Aug 4, 2016 at 10:27 AM, Navnath Gadakh
> <navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>
> >> Oh - does the per-server config override the main config? That's
> >> useful. So anything that's in test_advanced_config.py can be
> >> overridden on a per-server basis in test_config.py?
> >
> > No.
> > per-server i.e advance config(test_advanced_config.json.in) and main
> > config(test_config.json) both are different files. In main config we just
> > mention the server’s credentials.(We can also mention per server
> > credentails) and in test_advanced_config.json.in(here we say per-server
> > config)
> > we mention the advanced configurations i.e. test data for each node.
>
> OK.
>
> > So, let's summarize the discussion:
> > - Let user specify the tablespace path in
> test_advanced_config.json.in
>
> No - test_config.py. It should be per-server.
>
We don't have a file named 'test_config.py' but we have a server's
credential file named 'test_config.json'.
So, you are saying the tablespace path to be added in
'test_config.json'.
Am I correct?

>
> > - If path not specified in the test_advanced_config.json.in skip the
> > test cases for tablespace.
>
> Yes (but, test_config.py), for that server only.
>
> > - Output a notice saying the test was skipped, and note it in the
> > summary.
>
> Yes.
>
> > - No need to check the address.(Unix domain socket). It seems correct
> > way.
>
> Right.
>
> Thanks!
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>

--
Thanks,
Navnath Gadakh
Software Engineer
EnterpriseDB Corporation
Mobile: +91 9975389878