Re: RE-SQL tests patch for packages node

Please check now.

On Tue, Sep 3, 2019 at 5:07 PM Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
wrote:

> Hi Navnath
>
> You forgot to add "create_package_with_all_options_msql.sql" and
> "alter_package_headers_and_comment_msql.sql" file in your patch. Please
> send the updated patch.
>
> On Tue, Sep 3, 2019 at 1:36 PM navnath gadakh <
> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>
>> Hi,
>>
>> Please find the modified patch.
>>
>> On Mon, Sep 2, 2019 at 5:43 PM Akshay Joshi <
>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>
>>> Hi Navnath
>>>
>>> Following are the review comments:
>>>
>>> - GRANT statement is not visible in RE-SQL for create and alter
>>> both. (May be bug in Packages please fix that too)
>>>
>>> Done.
>>
>>>
>>> - Delete packages is missing in json file.
>>>
>>> Done.
>>
>>>
>>> - Add test cases to revoke privileges(delete all the privileges).
>>> Check Languages node for reference.
>>>
>>> Done.
>>
>>>
>>> On Mon, Sep 2, 2019 at 5:03 PM navnath gadakh <
>>> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>>>
>>>> Hi Dave,
>>>> Please find the patch for M-SQL test cases for *Packages*
>>>> module.
>>>>
>>>> Thanks!
>>>>
>>>> On Fri, Jul 12, 2019 at 4:02 PM Dave Page <dave(dot)page(at)enterprisedb(dot)com>
>>>> wrote:
>>>>
>>>>> Thanks, applied.
>>>>>
>>>>> On Fri, Jul 12, 2019 at 11:24 AM navnath gadakh <
>>>>> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>>>>>
>>>>>> Hi Dave,
>>>>>>
>>>>>> Please find the modified patch for packages as test cases were
>>>>>> failing on some servers.
>>>>>> Thanks!
>>>>>>
>>>>>>
>>>>>> On Thu, Jul 11, 2019 at 1:53 PM Dave Page <dave(dot)page(at)enterprisedb(dot)com>
>>>>>> wrote:
>>>>>>
>>>>>>> Thanks, applied.
>>>>>>>
>>>>>>> On Thu, Jul 11, 2019 at 8:07 AM Akshay Joshi <
>>>>>>> akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
>>>>>>>
>>>>>>>> Hi Navnath
>>>>>>>>
>>>>>>>> I have tested the patch and it is not working for EPAS 9.4, 9.5 and
>>>>>>>> 9.6. Attached is the modified patch which fix the issue.
>>>>>>>> Please work on child node (functions, procedure and variables) of
>>>>>>>> Packages on top of modified patch.
>>>>>>>>
>>>>>>>> On Wed, Jul 10, 2019 at 8:25 PM navnath gadakh <
>>>>>>>> navnath(dot)gadakh(at)enterprisedb(dot)com> wrote:
>>>>>>>>
>>>>>>>>> Hi Dave,
>>>>>>>>>
>>>>>>>>> I have attached the patch for RE-SQL test cases for *Packages*
>>>>>>>>> node.
>>>>>>>>>
>>>>>>>>> Thanks!
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> *Regards,*
>>>>>>>>> *Navnath Gadakh*
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Thanks & Regards*
>>>>>>>> *Akshay Joshi*
>>>>>>>>
>>>>>>>> *Sr. Software Architect*
>>>>>>>> *EnterpriseDB Software India Private Limited*
>>>>>>>> *Mobile: +91 976-788-8246*
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Dave Page
>>>>>>> VP, Chief Architect, Tools & Installers
>>>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>
>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>> Twitter: @pgsnake
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Regards,*
>>>>>> *Navnath Gadakh*
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> Dave Page
>>>>> VP, Chief Architect, Tools & Installers
>>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>> The Enterprise PostgreSQL Company
>>>>>
>>>>> Blog: http://pgsnake.blogspot.com
>>>>> Twitter: @pgsnake
>>>>>
>>>>
>>>>
>>>> --
>>>> *Regards,*
>>>> *Navnath Gadakh*
>>>>
>>>
>>>
>>> --
>>> *Thanks & Regards*
>>> *Akshay Joshi*
>>>
>>> *Sr. Software Architect*
>>> *EnterpriseDB Software India Private Limited*
>>> *Mobile: +91 976-788-8246*
>>>
>>
>>
>> --
>> *Regards,*
>> *Navnath Gadakh*
>>
>
>
> --
> *Thanks & Regards*
> *Akshay Joshi*
>
> *Sr. Software Architect*
> *EnterpriseDB Software India Private Limited*
> *Mobile: +91 976-788-8246*
>

--
*Regards,*
*Navnath Gadakh*